Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min rust version for windows-sys to 1.49 #1987

Merged
merged 1 commit into from Aug 29, 2022
Merged

Update min rust version for windows-sys to 1.49 #1987

merged 1 commit into from Aug 29, 2022

Conversation

kennykerr
Copy link
Collaborator

This update just bumps the minimum supported Rust version for the windows-sys crate from 1.46 to 1.49 to pick up some Cargo fixes needed to simplify the build, like the issue encountered in #1980. I chose 1.49 as that version has already been picked as the min version for the prominent parking_lot crate that depends on the windows-sys crate so should be broadly adopted.

@kennykerr kennykerr mentioned this pull request Aug 26, 2022
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable as 1.49 is over a year and a half old. However, it would be nice if we had a bit more formal of policy on MSRV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants