Remove unnecessary symbols and sections from *_gnu import libs #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sounds great! @riverar is this a no-brainer or should we discuss further with an issue? As I mentioned elsewhere, I'd like to avoid unnecessary churn in the targets if |
|
Merged #1967 - this PR now has merge conflicts - once that's cleared we can get it in - thanks! |
This cuts their size by more than 20% by removing what is essentially dead-weight: crates/targets/i686_gnu/lib/libwindows.a | Bin 14009016 -> 10924886 bytes crates/targets/x86_64_gnu/lib/libwindows.a | Bin 13879932 -> 10487912 bytes
riverar
approved these changes
Aug 22, 2022
|
Still surprising how much bigger the gnu libs are compared with msvc. 😟 |
|
This is just the legacy format of import libs. Short import libraries created by LLVM for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cuts their size by more than 20% by removing what is essentially
dead-weight:
crates/targets/i686_gnu/lib/libwindows.a | Bin 14009016 -> 10924886 bytes
crates/targets/x86_64_gnu/lib/libwindows.a | Bin 13879932 -> 10487912 bytes
Note this PR includes the commits from PR #1967 because github doesn't do PR dependencies.