Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the msvc target crates for gnullvm targets #1961

Closed
wants to merge 1 commit into from

Commits on Aug 14, 2022

  1. Use the msvc target crates for gnullvm targets

    The import libraries in crates/target/*_gnullvm only differ from the
    ones in crates/target/*_msvc the following ways:
    - their file name
    - they don't contain the second "/" linker member with symbol names in
      lexical order.
    - the members are not in the same order.
    
    That's about it. Both binutils ld and lld will happily find $lib.lib
    import libraries as well as lib$lib.a ones, so the file name doesn't
    matter. The other differences also don't have any practical consequence.
    
    This means it is not necessary to add extra crates for the purpose of
    the gnullvm target, especially when e.g. `cargo vendor` will want to
    vendor them all, and we can reuse the msvc ones, although their name
    could cause some confusion.
    glandium committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    2087b1b View commit details
    Browse the repository at this point in the history