Replace unsafe strlen usage in metadata library with safe Rust
#1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
Jul 21, 2022
There was a problem hiding this comment.
I'm personally in favor of most of the changes here:
- additional docs
- checking for utf-8 and panicking otherwise (using
from_utf8_uncheckedwas wrong)
I'm not sure that the dependency on memchar is worth it though. I would say we should accept these changes without the adoption of memchar. We can always change towards using memchar in the future if we encounter issues.
Removes the `unsafe` usage of C strlen and unchecked utf8 decoding from `File::str`, replacing it with safe (but panicing) Rust code. This also documents the method at the same time.
|
This dates back to when the metadata reader was primarily used from a proc macro and thus very slow. That's no longer a primary concern so this change looks good. |
kennykerr
approved these changes
Jul 21, 2022
kennykerr
changed the title
strlen usage in metadata library with safe Rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
unsafeusage of C strlen and unchecked utf8 decodingfrom
File::str, replacing it with safe (but panicing) Rust code.This also documents the method at the same time.
This pulls in the
memchrcrate, and uses almost the same code as the nightly-onlyCStr::from_bytes_until_nul.Not sure this subcrate by itself has any tests? So I’m not 100% confident of this change due to the lack of tests?