Fix HSTRING to conform to Rust's aliasing rules (#2057)

microsoft · Sep 22, 2022 · b13b328 · b13b328
1 parent 49317c3
commit b13b328
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/crates/libs/windows/src/core/strings/hstring.rs b/crates/libs/windows/src/core/strings/hstring.rs
@@ -408,11 +408,11 @@ impl Header {
         header
     }
 
-    fn duplicate(&mut self) -> *mut Header {
+    fn duplicate(&self) -> *mut Header {
         if self.flags & REFERENCE_FLAG == 0 {
             // If this is not a "fast pass" string then simply increment the reference count.
             self.count.add_ref();
-            self
+            self as *const Header as *mut Header
         } else {
             // Otherwise, allocate a new string and copy the value into the new string.
             let copy = Header::alloc(self.len);