This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
Update crate #36
Merged
Update crate #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cargo.lock should be gitignore'd for library crates. |
kennykerr
reviewed
Feb 27, 2022
kennykerr
reviewed
Mar 1, 2022
|
|
||
| fn main() { | ||
| let start = std::time::Instant::now(); | ||
| let mut output_path = std::path::PathBuf::from(windows_metadata::workspace_dir()); |
There was a problem hiding this comment.
The workspace_dir helper is going away - just use a relative path here.
kennykerr
previously approved these changes
Mar 1, 2022
|
Going to pause ⏸️ merging this until we can chat next week about some UX concerns. |
kennykerr
reviewed
Mar 20, 2022
kennykerr
reviewed
Mar 20, 2022
kennykerr
approved these changes
Mar 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds compatibility for
windows(0.34), samples, and interop helpers to unwrap Microsoft.UI types for GDI compatibility.Fixes #34, fixes #35