-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Azure build pipelines to OneBranch #1877
base: main
Are you sure you want to change the base?
Conversation
…f other signed binaries
packageType: sdk | ||
useGlobalJson: true | ||
|
||
# TODO - this no longer sets an Azure Devops pipeline build number, OneBranch has a different way of doing that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this TODO still pending?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, this Azure Devops pipeline name doesn't get properly set right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current release pipeline uses the pipeline build number so I don't think we can merge this until this is resolved.
Does it make sense to migrate the pipeline to GitHub Actions and call out to a backend for signing? |
No. It looks like we still have access to the existing pipelines, though, so I plan to push out a release this week. |
As part of compliance with updated security requirements, production pipelines must run in a 1ES environment. To do this, pipelines are converting to use OneBranch pipeline templates.
This changes how artifacts are published and the build environment is slightly different, resulting in some small changes to the build files.
As a backup plan, the existing azure pipeline scripts are left in place. These will be removed in the future.