Inconsistencies and missing entities in comparison with C++ and winapi-rs API

[ancwrd1]

I've been porting some projects from winapi-rs and from C++ to windows-rs, here is the list of inconsistencies found so far. I thought it might be a good idea to report them here.

• Win32::Graphics::Printing::MONITOR2 structure is supposed to hold callbacks, but it has generic isize fields instead. I think for the callbacks the fields should be Option<fn...>, like for the other similar APIs. #796
• RegisterEventSourceW returns EventSourceHandle, but ReportEventW accepts HANDLE.
• Many string constants are not being scraped #587 Some string constants are absent from the crate, need to define them manually: NCRYPT_NAME_PROPERTY, NCRYPT_PIN_PROPERTY, NCRYPT_PROVIDER_HANDLE_PROPERTY, etc
• Absent NCRYPT_HANDLE (isize) and HCERTSTORE (*const c_void) types
• Absent digest and encryption algorithms OIDs, e.g. OID_RSA_SHA256RSA
• Absent SECURITY_NT_AUTHORITY and similar defines #1482
• Many string constants are not being scraped #587 Absent SPLDS_xxx string constants
• Strange field names for DEVMODE inner unions: Anonymous1, Anonymous2 #1481
• Many string constants are not being scraped #587 Absent TRUSTED_PUBLISHER, LOCALE_NAME_SYSTEM_DEFAULT string constants
• Many string constants are not being scraped #587 Absent CERT_STORE_PROV_SYSTEM (and similar) constant
• Absent PRINTER_ALL_ACCESS constant
• Many native APIs accept const strings but with PWSTR I am always forced to cast to *mut u16

[kennykerr]

Thanks Dmitry! That's great feedback. These definitions come from the win32 metadata project so I'll transfer this issue for them to handle.

[mikebattista]

Many native APIs accept const strings but with PWSTR I am always forced to cast to *mut u16

Could you clarify what we could improve here?

[kennykerr]

Many native APIs accept const strings but with PWSTR I am always forced to cast to *mut u16

This is Rust-specific and has already been handled by the windows crate. See microsoft/windows-rs#1468 and microsoft/windows-rs#1470

[mikebattista]

Thanks. I will mark it completed.

[mikebattista]

Remaining tasks are tracked by separate issues.