Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many string constants are not being scraped #587

Closed
tim-weis opened this issue Jul 23, 2021 · 5 comments
Closed

Many string constants are not being scraped #587

tim-weis opened this issue Jul 23, 2021 · 5 comments
Assignees
@mikebattista @sotteson1
Labels
missing api Some documented API is missing from the metadata

Comments

@tim-weis
Copy link
Contributor

None of the BCrypt named constants (such as the CNG Algorithm Identifiers) wind up in the generated metadata. The same is true for named constants in Wincrypt (e.g. Constants for CryptEncodeObject and CryptDecodeObject). Having those in metadata, and ultimately in language projections would greatly help.
@mikebattista mikebattista added the missing api Some documented API is missing from the metadata label Aug 5, 2021
@mikebattista mikebattista self-assigned this Aug 5, 2021
@mikebattista
Copy link
Contributor

Thanks for filing. We'll add these and other string constants that are missing.

@mikebattista mikebattista mentioned this issue Aug 24, 2021
Closed
@mikebattista mikebattista mentioned this issue Nov 10, 2021
Closed
12 tasks
@mikebattista mikebattista changed the title None of the BCrypt named constants appear to make it into the metadata Many string constants are not being scraped Nov 10, 2021
@mikebattista
Copy link
Contributor

https://task.ms/37680910

@mikebattista
Copy link
Contributor

#610 was not addressed by this. Some of the constants missing from #720 were addressed, but others were not.

Could you take a look at the linked issues and add support for those string constants as well?

@mikebattista mikebattista reopened this Jan 18, 2022
@sotteson1
Copy link
Contributor

#610 was not addressed by this. Some of the constants missing from #720 were addressed, but others were not.

Could you take a look at the linked issues and add support for those string constants as well?

I think this latest fix addresses the ones I missed, but if you see some more let me know.

@mikebattista
Copy link
Contributor

Looks great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebattista mikebattista

@sotteson1 sotteson1

Labels
missing api Some documented API is missing from the metadata
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikebattista @sotteson1 @tim-weis