Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use environment variables for AeDebugger mode #4049

Merged
merged 6 commits into from Oct 10, 2022
Merged

Use environment variables for AeDebugger mode #4049

merged 6 commits into from Oct 10, 2022

Conversation

MarcoRossignoli
Copy link
Contributor

Use environment variables for AeDebugger mode

@MarcoRossignoli MarcoRossignoli marked this pull request as ready for review October 7, 2022 15:46
@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) October 7, 2022 15:46
Evangelink
Evangelink reviewed Oct 7, 2022
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do a better pass next week but I am posting some small nitpicks already.

src/Microsoft.TestPlatform.Execution.Shared/ProcDumpExecutableHelper.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.Extensions.BlameDataCollector/ProcDumpDumper.cs Outdated Show resolved Hide resolved
src/vstest.console/Processors/AeDebuggerArgumentProcessor.cs Outdated Show resolved Hide resolved
src/vstest.console/Resources/Resources.resx Outdated Show resolved Hide resolved
Marco Rossignoli and others added 3 commits October 7, 2022 18:45
address PR feedback
5e9c58e
@MarcoRossignoli @Evangelink
Update src/Microsoft.TestPlatform.Execution.Shared/ProcDumpExecutable…
1cfcd9d 
…Helper.cs

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
@MarcoRossignoli @Evangelink
Update src/vstest.console/Resources/Resources.resx
082dd7f 
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
@MarcoRossignoli
Copy link
Contributor Author

/azp run

@MarcoRossignoli MarcoRossignoli merged commit f5c8940 into microsoft:main Oct 10, 2022
@MarcoRossignoli MarcoRossignoli deleted the aepostmortemenvvar branch October 10, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

@nohwnd nohwnd Awaiting requested review from nohwnd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcoRossignoli @Evangelink