Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of diagnostics dependencies #3976

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

NikolaMilosavljevic
Copy link
Member

Fixes: dotnet/source-build#2970

Updates version of diagnostics dependency for source-build and related package versions.

@NikolaMilosavljevic
Copy link
Member Author

@Haplois I'm not able to add reviewers. Can you review this PR and add the Source-build devs? @MichaelSimons , @lbussell

@Haplois
Copy link
Contributor

Haplois commented Aug 26, 2022

@NikolaMilosavljevic, I can’t add them as reviewers since they don’t have write access I think. Would you like me to merge this PR?

@NikolaMilosavljevic
Copy link
Member Author

@NikolaMilosavljevic, I can’t add them as reviewers since they don’t have write access I think. Would you like me to merge this PR?

Yes, thank you!

@Haplois Haplois merged commit 1822911 into microsoft:main Aug 26, 2022
@NikolaMilosavljevic
Copy link
Member Author

@Haplois, I see that this change flowed to dotnet/SDK, but to the main branch. It is not being picked up by Maestro for 7.0.1xx update. Should we backport this change to a different microsoft/vstest branch, for this to happen? Or, should I backport this change in dotnet/sdk to a different sdk branch (i.e. release/7.0.1xx): dotnet/sdk#27524

@NikolaMilosavljevic
Copy link
Member Author

@Haplois, I see that this change flowed to dotnet/SDK, but to the main branch. It is not being picked up by Maestro for 7.0.1xx update. Should we backport this change to a different microsoft/vstest branch, for this to happen? Or, should I backport this change in dotnet/sdk to a different sdk branch (i.e. release/7.0.1xx): dotnet/sdk#27524

I've chosen to backport the dependency update, with: dotnet/sdk#27541 - thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update diagnostics version
2 participants