Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TargetLatestRuntimePatch properties #3969

Merged

Conversation

Evangelink
Copy link
Member

Description

Looking at history and after discussion in the team, it seems that this was added only to allow CheckEolTargetFramework that wasn't supported on older patches.

Looking at history and after discussion in the team, it seems that this was added only to allow CheckEolTargetFramework that wasn't supported on older patches.
@nohwnd
Copy link
Member

nohwnd commented Aug 25, 2022

Cool. This will also make #3968 work more reliably.

For future reference: The reason why using TargetLatestRuntimePatch is not desirable, is that this will force the runtimeconfig.json of testhost and other executables we produce to specify the latest version that the SDK we built with knows about (from the file mentioned in the comment "tools\dotnet\sdk<version from global json>\Microsoft.NETCoreSdk.BundledVersions.props" instead of using 3.1.xx for netcoreapp3.1, and 6.0.xx for net6 (etc.), no matter which sdk we built with. Forcing the higher version makes our executables less portable, and makes it more difficult to setup the CI machine.

@Evangelink Evangelink enabled auto-merge (squash) August 25, 2022 11:38
@Evangelink Evangelink merged commit b81e55a into microsoft:main Aug 25, 2022
@Evangelink Evangelink deleted the cleanup-TargetLatestRuntimePatch branch August 26, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants