Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark early testhost startup APIs as internal #2765

Closed

Conversation

cvpoienaru
Copy link
Member

Mark early testhost startup APIs as internal

@ghost
Copy link

ghost commented Feb 22, 2021

Hello @cvpoienaru!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 3 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change those internal APIs to internal?

@cvpoienaru
Copy link
Member Author

The APIs are already released in version 16.9.0-preview-20210106-01 because I split the early testhost startup work into two separate PRs for better management. Due to the project dependency graph, actually marking the APIs as internal will mean negating most of the work done in this PR.

However, a disclaimer should be enough to prevent external users from using those APIs.

@Haplois Haplois self-requested a review February 23, 2021 11:05
@Haplois
Copy link
Contributor

Haplois commented Feb 23, 2021

This work is continuing on #2768.

@Haplois Haplois closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants