Enable Fakes Datacollector settings to be added in design mode #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making this a draft because it looks like work in progress. |
AbhitejJohn
reviewed
Oct 9, 2020
test/Microsoft.TestPlatform.Common.UnitTests/Utilities/FakesUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
AbhitejJohn
reviewed
Oct 9, 2020
test/Microsoft.TestPlatform.Common.UnitTests/Utilities/FakesUtilitiesTests.cs
Show resolved
Hide resolved
AbhitejJohn
reviewed
Oct 9, 2020
AbhitejJohn
approved these changes
Oct 9, 2020
I planned for the VSUnitTesting side changes to go in separately, so that this can be available to users through the Microsoft.TestPlatform changes earlier |
nohwnd
reviewed
Oct 14, 2020
| @@ -267,11 +266,19 @@ public void RunTests(TestRunRequestPayload testRunRequestPayload, ITestHostLaunc | |||
| this.LogTelemetryForLegacySettings(requestData, runsettings); | |||
| } | |||
|
|
|||
| if (!commandLineOptions.IsDesignMode) | |||
| // get Fakes data collector settings | |||
| if (string.IsNullOrEmpty(Environment.GetEnvironmentVariable("_Disable_Fakes_DataCollector_Configuration"))) | |||
There was a problem hiding this comment.
Who would use this? We usually name env variables like this VSTEST__ (e.g. VSTEST_RUNNER_DEBUG`, and spell them in uppercase, in case some OSes would consider spelling when grabbing the variable. We also consider 0 to be off, not just null.
There was a problem hiding this comment.
This is for the users in the vstest task. By Shreyas' suggestion, if something is being enabled that wasn't before, it's best to have a fallback to be able to replicate previous behavior. I can change the var name and behavior to meet the standard in the vstest repo
…crosoft/vstest into dev/vrbhardw/fakes/vstestTask
This was referenced Mar 6, 2021
This was referenced Mar 13, 2021
This was referenced Mar 17, 2021
mburumaxwell
pushed a commit
to faluapp/falu-dotnet
that referenced
this pull request
Jun 12, 2021
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. #Release notes *Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases).* > ## v16.9.1 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1691). > > ## v16.9.0-preview-20210127-04 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1690-preview-20210127-04). > > ## v16.9.0-preview-20210106-01 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1690-preview-20210106-01). > > ## v16.9.0-preview-20201123-03 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1690-preview-20201123-03). > > ------------------------------- > > ## v16.9.0-preview-20201020-06 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1690-preview-20201020-06). > > ------------------------------- > > ## 16.9.0-preview-20201020-06 > > ### Issue Fixed > * Enable Fakes Datacollector settings to be added in design mode [#2586](microsoft/vstest#2586) > * Fix blame parameter, warning, and add all testhosts to be ngend [#2579](microsoft/vstest#2579) > * Add netcoreapp1.0 support to `Microsoft.TestPlatform.TestHost` NuGet [#2569](microsoft/vstest#2569) > * Use bitness from process or OS [#2571](microsoft/vstest#2571) > * Restore netcoreapp1.0 support for testhost [#2554](microsoft/vstest#2554) > * Get symbols of DiaSymReader from externals [#2560](microsoft/vstest#2560) > * Do not force .NET4.5 in case legacy test settings are provided [#2545](microsoft/vstest#2545) > * Simplify package references [#2559](microsoft/vstest#2559) > * Enable default compile items for Microsoft.TestPlatform.PlatformAbstractions [#2556](microsoft/vstest#2556) > * Avoid logging >Task returned false but did not log an error.< [#2557](microsoft/vstest#2557) > * Fixed code coverage compatibility issue [#2527](microsoft/vstest#2527) > * Add environment variables to enable MacOS dump > * Adding test run attachments processing [#2463](microsoft/vstest#2463) > > See full log [here](microsoft/vstest@v16.8.0-release-20200921-02...v16.9.0-preview-20201020-06) > > ### Drops > > * TestPlatform vsix: [16.9.0-preview-20201020-06](https://vsdrop.corp.microsoft.com/file/v1/Products/DevDiv/microsoft/vstest/master/20201020-06;/TestPlatform.vsix) > * Microsoft.TestPlatform.ObjectModel : [16.9.0-preview-20201020-06](https://www.nuget.org/packages/Microsoft.TestPlatform.ObjectModel/16.9.0-preview-20201020-06) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable the VSTest V2 task scenario, where the code calling into the vstest.console cannot be overridden.
TODO:
Validate vstest task with this change on existing reposValidate VS scenarios