Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timers to the TestResult, and update the TRX logger to output the timer information #2208

Closed
wants to merge 3 commits into from

Conversation

robdalsanto
Copy link

Add timers to the TestResult, and update the TRX logger output the timer
information to the TRX file if any timers are in the collection, as per
the XML schema of the TRX from
%VSINSTALLDIR%\xml\Schemas\vstst.xsd

It looks almost like an oversight that the TestResult did not previously include
the named timers.

Related issues

output the timer information to the TRX file if any timers
are in the collection, as per the XML schema of the TRX from
%VSINSTALLDIR%\xml\Schemas\vstst.xsd
@msftclas
Copy link

msftclas commented Oct 1, 2019

CLA assistant check
All CLA requirements met.

@robdalsanto
Copy link
Author

Added fix for failing unit test by adding commit 'df5213197b38378a712a544a6d095975cd737e31' to the pull request.

Removed a RESX string and replaced with a literal string, and
added summary comments.
@robdalsanto
Copy link
Author

@singhsarab I addressed your review comments. Thanks for the input.
It looks like there was some problem in the build unrelated to my changes (see here). I can't find a way to re-queue a build. Can you provide me any guidance so this doesn't stall ?

@singhsarab
Copy link
Contributor

@robdalsanto Could you please attach a sample trx with the change ?

@singhsarab
Copy link
Contributor

We need some tests, acceptance and unit for this change.

@HeroMaxPower
Copy link
Contributor

@robdalsanto could you make some acceptance tests?

@robdalsanto
Copy link
Author

robdalsanto commented Mar 10, 2020 via email

@nohwnd nohwnd added this to the 16.7.0 milestone Mar 11, 2020
@nohwnd
Copy link
Member

nohwnd commented Mar 11, 2020

Looks like a nice change, that is only missing tests, adding for consideration in 16.7.0.

@pavelhorak pavelhorak modified the milestones: 16.7.0, 16.8.0 Apr 20, 2020
@pavelhorak pavelhorak modified the milestones: 16.8.0, 16.9.0 Oct 1, 2020
@pavelhorak pavelhorak modified the milestones: 16.9.0, 16.10 Mar 1, 2021
@Evangelink Evangelink removed this from the 16.10 milestone Aug 3, 2022
@Evangelink
Copy link
Member

@robdalsanto We know it's been a really long time but would you be able to work on the tests or do you want us to take it over?

@robdalsanto
Copy link
Author

robdalsanto commented Aug 4, 2022 via email

@Evangelink
Copy link
Member

@robdalsanto No worries, thanks for letting us know!

@MarcoRossignoli
Copy link
Contributor

I'm going to close for stale state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants