Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect timeout message when test host crashes/exits #2056

Merged
merged 6 commits into from Jun 19, 2019
Merged

Fixed incorrect timeout message when test host crashes/exits #2056

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
760622c
Fixed incorrect timeout message when test host crashes/exits
ShreyasRmsft Jun 13, 2019
aafe3a0
Added tests
ShreyasRmsft Jun 18, 2019
c8f1366
Merge branch 'users/ShreyasRMsft/fixedIncorrectConnectionTimeoutError…
ShreyasRmsft Jun 18, 2019
c77ebf3
Update ProxyExecutionManagerTests.cs
ShreyasRmsft Jun 18, 2019
15d9ec2
Update ProxyOperationManager.cs
ShreyasRmsft Jun 18, 2019
08f3fa4
Update ProxyExecutionManagerTests.cs
ShreyasRmsft Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.cs.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">Proces testovacího hostitele se chybově ukončil.</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.de.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">Der Testhostprozess ist abgestürzt.</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.es.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">Proceso de host de pruebas bloqueado</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.fr.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">Plantage du processus hôte de test</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.it.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">Arresto anomalo del processo host di test</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.ja.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">テストのホスト プロセスがクラッシュしました</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.ko.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">테스트 호스트 프로세스 작동이 중단됨</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.pl.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">Wystąpiła awaria procesu hosta testu</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.pt-BR.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">Falha no processo do host de teste</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.ru.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">Сбой хост-процесса теста</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.tr.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">Test ana işlemi kilitlendi</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.zh-Hans.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">测试主机进程崩溃</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.CommunicationUtilities/Resources/xlf/Resources.zh-Hant.xlf
View file
Open in desktop
Expand Up @@ -79,8 +79,7 @@
<trans-unit id="TestHostProcessCrashed">
<source>Test host process crashed</source>
<target state="translated">測試主機處理序當機</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
9 changes: 9 additions & 0 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
View file
Open in desktop
Expand Up @@ -161,6 +161,7 @@ public virtual bool SetupChannel(IEnumerable<string> sources)
!this.RequestSender.WaitForRequestHandlerConnection(connTimeout * 1000, this.CancellationTokenSource.Token))
{
this.CancellationTokenSource.Token.ThrowTestPlatformExceptionIfCancellationRequested();
this.ThrowOnTestHostExited(this.testHostExited.IsSet);
ShreyasRmsft marked this conversation as resolved.
Show resolved Hide resolved
this.ThrowExceptionOnConnectionFailure(connTimeout);
}

Expand Down Expand Up @@ -306,6 +307,14 @@ private void TestHostManagerHostExited(object sender, HostProviderEventArgs e)
this.testHostExited.Set();
}

private void ThrowOnTestHostExited(bool testHostExited)
{
if (testHostExited)
{
throw new TestPlatformException(string.Format(CrossPlatEngineResources.TestHostExitedWithError, this.testHostProcessStdError));
}
}

private void ThrowExceptionOnConnectionFailure(int connTimeout)
{
// Failed to launch testhost process.
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TestPlatform.CrossPlatEngine/Resources/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/Microsoft.TestPlatform.CrossPlatEngine/Resources/Resources.resx
View file
Open in desktop
Expand Up @@ -169,7 +169,7 @@
<value>Logging TestHost Diagnostics in file: {0}</value>
</data>
<data name="TestHostExitedWithError" xml:space="preserve">
<value>Testhost process exited with error: {0}</value>
<value>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</value>
</data>
<data name="TestRunFailed_NoDiscovererFound_NoTestsAreAvailableInTheSources" xml:space="preserve">
<value>No test is available in {0}. Make sure that test discoverer &amp; executors are registered and platform &amp; framework version settings are appropriate and try again.</value>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.cs.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Proces hostitele testu se ukončil s chybou: {0}</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Proces hostitele testu se ukončil s chybou: {0}</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.de.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Der Testhostprozess wurde mit dem Fehler {0} beendet.</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Der Testhostprozess wurde mit dem Fehler {0} beendet.</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.es.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">El proceso del host de pruebas se cerró con el error {0}</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">El proceso del host de pruebas se cerró con el error {0}</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.fr.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Le processus testhost s'est arrêté avec l'erreur : {0}.</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Le processus testhost s'est arrêté avec l'erreur : {0}.</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.it.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Il processo host dei test è terminato con l'errore {0}</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Il processo host dei test è terminato con l'errore {0}</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.ja.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Testhost プロセスが次のエラーにより終了しました: {0}</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Testhost プロセスが次のエラーにより終了しました: {0}</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.ko.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Testhost 프로세스가 종료되었습니다(오류: {0}).</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Testhost 프로세스가 종료되었습니다(오류: {0}).</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.pl.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Proces testhost zakończył się z błędem: {0}</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Proces testhost zakończył się z błędem: {0}</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.pt-BR.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Processo de testhood encerrado com erro: {0}</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Processo de testhood encerrado com erro: {0}</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.ru.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Процесс testhost завершен с ошибкой {0}</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Процесс testhost завершен с ошибкой {0}</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.tr.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Testhost işleminden hata ile çıkıldı: {0}</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Testhost işleminden hata ile çıkıldı: {0}</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.xlf
View file
Open in desktop
Expand Up @@ -64,7 +64,7 @@
<note></note>
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Testhost process exited with error: {0}</target>
<note></note>
</trans-unit>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.zh-Hans.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Testhost 进程已退出，并显示错误: {0}。</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Testhost 进程已退出，并显示错误: {0}。</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.CrossPlatEngine/Resources/xlf/Resources.zh-Hant.xlf
View file
Open in desktop
Expand Up @@ -153,9 +153,9 @@
<note />
</trans-unit>
<trans-unit id="TestHostExitedWithError">
<source>Testhost process exited with error: {0}</source>
<target state="translated">Testhost 處理序已結束。錯誤: {0}</target>
<note />
<source>Testhost process exited with error: {0}. Please check the diagnostic logs for more information.</source>
<target state="new">Testhost 處理序已結束。錯誤: {0}</target>
<note></note>
</trans-unit>
<trans-unit id="DataCollectorDebuggerWarning">
<source>DataCollector debugging is enabled. Please attach debugger to datacollector process to continue.</source>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/xlf/Resources.cs.xlf
View file
Open in desktop
Expand Up @@ -59,8 +59,7 @@
<trans-unit id="InvalidFilePath">
<source>File {0} does not exists</source>
<target state="translated">Soubor {0} neexistuje.</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/xlf/Resources.de.xlf
View file
Open in desktop
Expand Up @@ -59,8 +59,7 @@
<trans-unit id="InvalidFilePath">
<source>File {0} does not exists</source>
<target state="translated">Die Datei "{0}" ist nicht vorhanden.</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/xlf/Resources.es.xlf
View file
Open in desktop
Expand Up @@ -59,8 +59,7 @@
<trans-unit id="InvalidFilePath">
<source>File {0} does not exists</source>
<target state="translated">El archivo {0} no existe</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/xlf/Resources.fr.xlf
View file
Open in desktop
Expand Up @@ -59,8 +59,7 @@
<trans-unit id="InvalidFilePath">
<source>File {0} does not exists</source>
<target state="translated">Le fichier {0} n'existe pas</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down
3 changes: 1 addition & 2 deletions src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Resources/xlf/Resources.it.xlf
View file
Open in desktop
Expand Up @@ -59,8 +59,7 @@
<trans-unit id="InvalidFilePath">
<source>File {0} does not exists</source>
<target state="translated">Il file {0} non esiste</target>
<note>
</note>
<note></note>
</trans-unit>
</body>
</file>
Expand Down