TestRunRequestEventsRegistrar null in run specific tests

src/vstest.console/Processors/RunSpecificTestsArgumentProcessor.cs

@@ -137,6 +137,11 @@ internal class RunSpecificTestsArgumentExecutor : IArgumentExecutor
         /// </summary>
         private ITestDiscoveryEventsRegistrar discoveryEventsRegistrar;
 
+        /// <summary>
+        /// Registers and Unregisters for test run events before and after test run
+        /// </summary>
+        private ITestRunEventsRegistrar testRunEventsRegistrar;
+
         #endregion
 
         #region Constructor
@@ -159,6 +164,7 @@ internal class RunSpecificTestsArgumentExecutor : IArgumentExecutor
             this.runSettingsManager = runSettingsProvider;
             this.output = output;
             this.discoveryEventsRegistrar = new DiscoveryEventsRegistrar(this.discoveryRequest_OnDiscoveredTests);
+            this.testRunEventsRegistrar = new TestRunRequestEventsRegistrar(this.output, this.commandLineOptions);
         }
 
         #endregion
@@ -259,7 +265,7 @@ private void ExecuteSelectedTests()
 
                 EqtTrace.Verbose("RunSpecificTestsArgumentProcessor:Execute: Test run is queued.");
                 var runRequestPayload = new TestRunRequestPayload() { TestCases = this.selectedTestCases.ToList(), RunSettings = this.effectiveRunSettings, KeepAlive = keepAlive, TestPlatformOptions = new TestPlatformOptions() { TestCaseFilter = this.commandLineOptions.TestCaseFilterValue }};
-                this.testRequestManager.RunTests(runRequestPayload, null, null, Constants.DefaultProtocolConfig);
+                this.testRequestManager.RunTests(runRequestPayload, null, this.testRunEventsRegistrar, Constants.DefaultProtocolConfig);
             }
             else
             {
@@ -335,5 +341,53 @@ public void UnregisterDiscoveryEvents(IDiscoveryRequest discoveryRequest)
                 discoveryRequest.OnDiscoveredTests -= this.discoveredTestsHandler;
             }
         }
+
+        private class TestRunRequestEventsRegistrar : ITestRunEventsRegistrar
+        {
+            private IOutput output;
+            private CommandLineOptions commandLineOptions;
+
+            public TestRunRequestEventsRegistrar(IOutput output, CommandLineOptions commandLineOptions)
+            {
+                this.output = output;
+                this.commandLineOptions = commandLineOptions;
+            }
+
+            public void LogWarning(string message)
+            {
+                ConsoleLogger.RaiseTestRunWarning(message);
+            }
+
+            public void RegisterTestRunEvents(ITestRunRequest testRunRequest)
+            {
+                testRunRequest.OnRunCompletion += TestRunRequest_OnRunCompletion;
+            }
+
+            public void UnregisterTestRunEvents(ITestRunRequest testRunRequest)
+            {
+                testRunRequest.OnRunCompletion -= TestRunRequest_OnRunCompletion;
+            }
+
+            /// <summary>
+            /// Handles the TestRunRequest complete event
+            /// </summary>
+            /// <param name="sender"></param>
+            /// <param name="e">RunCompletion args</param>
+            private void TestRunRequest_OnRunCompletion(object sender, TestRunCompleteEventArgs e)
+            {
+                // If run is not aborted/cancelled then check the count of executed tests.
+                // we need to check if there are any tests executed - to try show some help info to user to check for installed vsix extensions
+                if (!e.IsAborted && !e.IsCanceled)
+                {
+                    var testsFoundInAnySource = (e.TestRunStatistics == null) ? false : (e.TestRunStatistics.ExecutedTests > 0);
+
+                    // Indicate the user to use testadapterpath command if there are no tests found
+                    if (!testsFoundInAnySource && string.IsNullOrEmpty(CommandLineOptions.Instance.TestAdapterPath) && this.commandLineOptions.TestCaseFilterValue == null)
+                    {
+                        this.output.Warning(false, CommandLineResources.SuggestTestAdapterPathIfNoTestsIsFound);
+                    }
+                }
+            }
+        }
     }
 }

src/vstest.console/TestPlatformHelpers/TestRequestManager.cs

@@ -435,7 +435,7 @@ private void CheckSourcesForCompatibility(Framework chosenFramework, Architectur
             if (!string.IsNullOrEmpty(incompatibleSettingWarning))
             {
                 EqtTrace.Warning(incompatibleSettingWarning);
-                registrar.LogWarning(incompatibleSettingWarning);
+                registrar?.LogWarning(incompatibleSettingWarning);
             }
 
             // Log compatible sources

test/Microsoft.TestPlatform.AcceptanceTests/FrameworkTests.cs

@@ -50,5 +50,29 @@ public void OnWrongFrameworkPassedTestRunShouldNotRun(RunnerInfo runnerInfo)
                 this.StdErrorContains("Test Run Aborted.");
             }
         }
+
+        [TestMethod]
+        [NetFullTargetFrameworkDataSource]
+        [NetCoreTargetFrameworkDataSource]
+        public void RunSpecificTestsShouldWorkWithFrameworkInCompatibleWarning(RunnerInfo runnerInfo)
+        {
+            AcceptanceTestBase.SetTestEnvironment(this.testEnvironment, runnerInfo);
+
+            var arguments = PrepareArguments(GetSampleTestAssembly(), string.Empty, string.Empty, this.FrameworkArgValue);
+            arguments = string.Concat(arguments, " ", "/tests:PassingTest");
+            arguments = string.Concat(arguments, " ", "/Framework:Framework40");
+
+            this.InvokeVsTest(arguments);
+
+            if (runnerInfo.TargetFramework.Contains("netcore"))
+            {
+                this.StdOutputContains("No test is available");
+            }
+            else
+            {
+                this.StdOutputContains("Following DLL(s) do not match framework/platform settings. ");
+                this.ValidateSummaryStatus(1, 0, 0);
+            }
+        }
     }
 }