Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing ESM-comment-* block #80417

Closed
wants to merge 1 commit into from
Closed

add missing ESM-comment-* block #80417

wants to merge 1 commit into from

Conversation

jsteuer
Copy link

@jsteuer jsteuer commented Sep 5, 2019

hopefully this will fix broken monaco-editor (version 18.0.0), see microsoft/monaco-editor#1574

this will fix broken monaco-editor (version 18.0.0), see microsoft/monaco-editor#1574
@sbatten sbatten requested review from alexdima and removed request for alexdima September 5, 2019 17:46
@akphi
Copy link

akphi commented Sep 6, 2019

@alexandrudima Could you also please take a look at this little annoying warning abound critical dependency?

@alexdima alexdima added this to the September 2019 milestone Sep 6, 2019
@alexdima alexdima added the important Issue identified as high-priority label Sep 6, 2019
@alexdima
Copy link
Member

Thank you, but I decided to tweak the file in a different way to align with marked.js...

@alexdima alexdima closed this Sep 19, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
important Issue identified as high-priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants