enable easy configuration of unassigned keybindings for extension contributed accessibility help dialogs #212997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
changed the title
roblourens
reviewed
May 18, 2024
| return; | ||
| } | ||
| const quickPick: IQuickPick<IQuickPickItem> = this._quickInputService.createQuickPick(); | ||
| this._register(quickPick); |
There was a problem hiding this comment.
You should dispose the quickpick when you're done with it, and the listeners below should also be disposed
There was a problem hiding this comment.
I think I do on lines 381 and 383. The listeners are registered to the quick pick I believe?
roblourens
approved these changes
May 18, 2024
johnyongbeyondsoft
pushed a commit
to johnyongbeyondsoft/vscode
that referenced
this pull request
May 20, 2024
…bility help dialogs (microsoft#212997)
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
May 22, 2024
…bility help dialogs (microsoft#212997)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #210665
The parsing/keybinding resolution will move into the
AccessibleViewServiceor a helper class when I next work on #210695. This is just a step in that direction.demo.mov