Add notebook Format On Cell Execution #182924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
May 18, 2023
src/vs/workbench/contrib/notebook/browser/services/notebookExecutionServiceImpl.ts
Outdated
Show resolved
Hide resolved
roblourens
reviewed
May 20, 2023
src/vs/workbench/contrib/notebook/browser/notebook.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/notebook.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/services/notebookExecutionStateServiceImpl.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/notebook/browser/services/notebookExecutionServiceImpl.ts
Outdated
Show resolved
Hide resolved
rebornix
approved these changes
May 22, 2023
roblourens
reviewed
May 22, 2023
| return toDisposable(() => this.cellExecutionParticipants.delete(participant)); | ||
| } | ||
|
|
||
| async runExecutionParticipants(executions: INotebookCellExecution[]): Promise<void> { |
There was a problem hiding this comment.
This should be private unless there's a reason to expose it publicly
There was a problem hiding this comment.
Fixed by: 183164, missed your point on the first read through. Appreciate the help and review through this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: vscode-jupyter/7058
Hook into
NotebookExecutionServiceand add support for formatting cells upon execution. UsesvalidCellExecutionsand formats based on cells present in that array.Formatting is implemented similar to what is used in src\vs\workbench\contrib\notebook\browser\contrib\format\formatting.ts and src\vs\workbench\contrib\notebook\browser\contrib\saveParticipants\saveParticipants.ts. Could this be reworked into a different location where multiple spots could leverage the same formatter? Rather than just reusing code in various locations.