Revert "Update xterm.js" #164002
Merged
Revert "Update xterm.js" #164002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandy081
approved these changes
Oct 19, 2022
|
(Assuming this is the same issue as I'm experiencing:) I think it does come up, it's just scrolled out of viewport. Press enter a few times, and it should scroll into view. The terminal is also strangely "halved", e.g. not the full width of the pane is used.
|
|
Thanks for the revert, we'll look into it today |
|
@meganrogge oh, the new version with your fix also includes xtermjs/xterm.js#4207 which breaks some of our internal API access. |
meganrogge
pushed a commit
that referenced
this pull request
Oct 19, 2022
* Revert "Revert "Update xterm.js" (#164002)" This reverts commit 462ecfa. * Adopt xterm internal API change See xtermjs/xterm.js#4207
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this pull request
Nov 25, 2022
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this pull request
Nov 25, 2022
* Revert "Revert "Update xterm.js" (microsoft#164002)" This reverts commit 462ecfa. * Adopt xterm internal API change See xtermjs/xterm.js#4207
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #163183 because the terminal prompt doesn't come up:
Kapture.2022-10-19.at.10.31.35.mp4
FYI @Tyriar @meganrogge