-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: notify windows 7 support eol #159546
Conversation
Great PR, just add translations to file. |
Easier somewhere here: vscode/src/vs/workbench/electron-sandbox/window.ts Lines 623 to 624 in 933c22a
And maybe using |
d6bc3ad
to
5700054
Compare
Will it still auto-update to 1.71 (and therefore broken) for Win7 users? |
Nope, windows 7 users received the final update yesterday which is |
Could you please also include a documentation on this Windows 7-specific version in some easy-to-find way? |
/cc @gregvanl ☝️ |
Added mention of 1.70.3 Windows 7 only release with microsoft/vscode-docs@968ca62 |
Instead of dropping support for Windows 7, someone could just fix Electron 19 on Windows 7 and VSCode would still be working... electron/electron#35219 |
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/3119