Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notify windows 7 support eol #159546

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix: notify windows 7 support eol #159546

merged 1 commit into from
Aug 30, 2022

Conversation

deepak1556
Copy link
Contributor

@deepak1556 deepak1556 self-assigned this Aug 30, 2022
@deepak1556 deepak1556 added this to the On Deck milestone Aug 30, 2022
@dzienisz
Copy link

Great PR, just add translations to file.

@bpasero
Copy link
Member

bpasero commented Aug 30, 2022

Easier somewhere here:

// Integrity warning
this.integrityService.isPure().then(({ isPure }) => this.titleService.updateProperties({ isPure }));

And maybe using INativeWorkbenchEnvironmentService.os.release. And maybe using productService.nameLong instead of hardcoding VSCode.

@joaomoreno joaomoreno modified the milestones: On Deck, August 2022 Aug 30, 2022
@joaomoreno joaomoreno merged commit 65b53f2 into main Aug 30, 2022
@joaomoreno joaomoreno deleted the robo/notify_win7_users branch August 30, 2022 19:02
mjbvz pushed a commit to mjbvz/vscode that referenced this pull request Aug 30, 2022
mjbvz added a commit that referenced this pull request Aug 30, 2022
Co-authored-by: Robo <hop2deep@gmail.com>
@fireattack
Copy link

Will it still auto-update to 1.71 (and therefore broken) for Win7 users?

@deepak1556
Copy link
Contributor Author

deepak1556 commented Sep 1, 2022

Nope, windows 7 users received the final update yesterday which is 1.70.3 which includes the above notification and it will not receive further version updates or auto-update to any newer version. Basically, it won't auto update to the broken version.

@infinnie
Copy link
Contributor

infinnie commented Sep 2, 2022

Nope, windows 7 users received the final update yesterday which is 1.70.3 which includes the above notification and it will not receive further version updates or auto-update to any newer version. Basically, it won't auto update to the broken version.

Could you please also include a documentation on this Windows 7-specific version in some easy-to-find way?

@deepak1556
Copy link
Contributor Author

/cc @gregvanl ☝️

@gregvanl
Copy link

gregvanl commented Sep 2, 2022

Added mention of 1.70.3 Windows 7 only release with microsoft/vscode-docs@968ca62

@lorand-horvath
Copy link

Instead of dropping support for Windows 7, someone could just fix Electron 19 on Windows 7 and VSCode would still be working... electron/electron#35219

@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants