chore: update to electron 11 #110759

deepak1556 · 2020-11-16T22:16:31Z

Electron release link - https://github.com/electron/electron/releases/tag/v11.0.2

Keytar chore: bump keytar@7.1.0 #110815, chore: bump keytar@7.2.0 #110977
vscode-windows-ca-certs fix: crash with v8 8.7 vscode-windows-ca-certs#1

deepak1556 · 2020-11-17T16:36:48Z

build/azure-pipelines/product-build.yml

+  - Compile
+  condition: and(succeeded(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'))
+  pool:
+    vmImage: macOS-latest


For now we are cross-compiling but when ci supports native compilation, it will be using a different pool. Hence this is written as a separate stage.

deepak1556 · 2020-11-19T13:52:31Z

package.json

@@ -191,9 +191,10 @@
    "url": "https://github.com/microsoft/vscode/issues"
  },
  "optionalDependencies": {
+    "vscode-windows-ca-certs": "^0.3.0",


The version bump cannot be done in current master because of new napi version.

deepak1556 · 2020-11-19T13:55:26Z

build/azure-pipelines/product-build.yml

+    vmImage: macOS-latest
+  jobs:
+  - job: macOSARM64
+    condition: and(succeeded(), eq(variables['VSCODE_BUILD_MACOS_ARM64'], 'true'))


Turning this off for now because internal mac arm builds are not available yet, there is active work to get a release out sometime next week.

deepak1556 · 2020-11-20T19:12:50Z

package.json

@@ -1,7 +1,7 @@
 {
  "name": "code-oss-dev",
  "version": "1.52.0",
-  "distro": "e289d0d793bde8f8b5632625e01c50c218e7e127",
+  "distro": "bedb1d87b28d90d8cf83deb8f334816a05980fb4",


This is just to fix conflicts with distro and get exploration builds out from this branch, will remove this before merging and fix conflicts on distro branch.

deepak1556 · 2020-11-20T19:13:16Z

This is now ready for review, also last night's exploration release was made from this branch

@bpasero - can you review the electron api changes
@joaomoreno - can you review the build pipeline changes and install-update api changes
@chrmarti - can you review vscode-windows-ca-certs changes

Thanks!

bpasero · 2020-11-21T07:17:56Z

.yarnrc

@@ -1,3 +1,3 @@
 disturl "https://electronjs.org/headers"
-target "9.3.3"
+target "11.0.2"


I think we are not yet having internal builds for this right?

yup, will merge once the builds are available, can expect them in beginning of next week.

chrmarti

Looks good. Thanks!

chrmarti · 2020-11-23T08:51:23Z

src/vs/code/test/electron-main/nativeHelpers.test.ts

+		} finally {
+			store.done();
+		}
+		assert(certCount > 0);


On a fresh Windows machine the cert store might have very few certificates because Edge downloads and adds to it on demand. Not sure if it can be empty, but if we see this test failing we need to consider that possibility.

joaomoreno

lgtm

bpasero · 2020-11-23T10:51:15Z

@deepak1556 looks like we can also remove this code now, no?

vscode/src/vs/platform/windows/common/windows.ts

Lines 129 to 132 in 38f55ec

    
           const isDev = !environment.isBuilt || isExtensionDevelopment; 
        
           if (isMacintosh && isDev) { 
        
           	return 'native'; // not enabled when developing due to https://github.com/electron/electron/issues/3647 
        
           }

deepak1556 · 2020-11-23T16:01:09Z

@deepak1556 looks like we can also remove this code now, no?

Good catch, will remove it. Thanks!

electron/electron#26395

deepak1556 · 2020-11-23T20:19:47Z

@sbatten can you review c21f001 which addresses #110759 (comment)

Reason for change: Electron has fixed the issue in electron/electron#26395

deepak1556 mentioned this pull request Nov 17, 2020

fix: crash with v8 8.7 microsoft/vscode-windows-ca-certs#1

Merged

deepak1556 commented Nov 17, 2020

View reviewed changes

roblourens assigned deepak1556 Nov 17, 2020

deepak1556 force-pushed the robo/update_electron_11 branch 2 times, most recently from f056162 to 86c32f1 Compare November 19, 2020 12:47

deepak1556 commented Nov 19, 2020

View reviewed changes

deepak1556 mentioned this pull request Nov 19, 2020

Restart to Update has a huge delay #105114

Closed

deepak1556 force-pushed the robo/update_electron_11 branch 2 times, most recently from efa785e to 04787ef Compare November 20, 2020 07:56

deepak1556 marked this pull request as ready for review November 20, 2020 19:12

deepak1556 commented Nov 20, 2020

View reviewed changes

deepak1556 requested review from joaomoreno, bpasero and chrmarti November 20, 2020 19:14

bpasero approved these changes Nov 21, 2020

View reviewed changes

deepak1556 mentioned this pull request Nov 21, 2020

Native wayland support with newest electron #109176

Closed

chrmarti approved these changes Nov 23, 2020

View reviewed changes

joaomoreno approved these changes Nov 23, 2020

View reviewed changes

egamma mentioned this pull request Nov 23, 2020

Iteration Plan for November 2020 #110690

Closed

65 tasks

deepak1556 added 6 commits November 23, 2020 09:58

chore: bump electron@11.0.0-beta.4

2232109

build: add mac arm64 target

111fbb3

chore: bump electron@11.0.1

f5b5a4a

fix: remove macOS workaround for devtools with custom titlebar

407198c

electron/electron#26395

chore: bump vscode-windows-ca-certs@0.3.0

2f4a3dc

chore: bump electron@11.0.2

0151976

deepak1556 force-pushed the robo/update_electron_11 branch from 88c7381 to 0151976 Compare November 23, 2020 18:08

fixup! remove macOS workaround for devtools with custom titlebar

c21f001

deepak1556 requested a review from sbatten November 23, 2020 20:20

sbatten approved these changes Nov 23, 2020

View reviewed changes

deepak1556 merged commit 0baf6bb into master Nov 23, 2020

deepak1556 deleted the robo/update_electron_11 branch November 23, 2020 23:31

deepak1556 mentioned this pull request Dec 5, 2020

chore: bump electron@11.0.3 #111931

Merged

kieferrm mentioned this pull request Dec 14, 2020

Iteration Plan for January 2021 #112419

Closed

73 tasks

github-actions bot locked and limited conversation to collaborators Jan 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update to electron 11 #110759

chore: update to electron 11 #110759

deepak1556 commented Nov 16, 2020 •

edited

deepak1556 Nov 17, 2020

deepak1556 Nov 19, 2020

deepak1556 Nov 19, 2020

deepak1556 Nov 20, 2020

deepak1556 commented Nov 20, 2020 •

edited

bpasero Nov 21, 2020

deepak1556 Nov 21, 2020

chrmarti left a comment

chrmarti Nov 23, 2020

joaomoreno left a comment

bpasero commented Nov 23, 2020

deepak1556 commented Nov 23, 2020

deepak1556 commented Nov 23, 2020

chore: update to electron 11 #110759

chore: update to electron 11 #110759

Conversation

deepak1556 commented Nov 16, 2020 • edited

deepak1556 Nov 17, 2020

Choose a reason for hiding this comment

deepak1556 Nov 19, 2020

Choose a reason for hiding this comment

deepak1556 Nov 19, 2020

Choose a reason for hiding this comment

deepak1556 Nov 20, 2020

Choose a reason for hiding this comment

deepak1556 commented Nov 20, 2020 • edited

bpasero Nov 21, 2020

Choose a reason for hiding this comment

deepak1556 Nov 21, 2020

Choose a reason for hiding this comment

chrmarti left a comment

Choose a reason for hiding this comment

chrmarti Nov 23, 2020

Choose a reason for hiding this comment

joaomoreno left a comment

Choose a reason for hiding this comment

bpasero commented Nov 23, 2020

deepak1556 commented Nov 23, 2020

deepak1556 commented Nov 23, 2020

deepak1556 commented Nov 16, 2020 •

edited

deepak1556 commented Nov 20, 2020 •

edited