Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt setting terminal renderer before Terminal.open is called #162973

Closed
Tyriar opened this issue Oct 7, 2022 · 1 comment · Fixed by #162982
Closed

Adopt setting terminal renderer before Terminal.open is called #162973

Tyriar opened this issue Oct 7, 2022 · 1 comment · Fixed by #162982
Assignees
@Tyriar
Labels
debt Code quality issues *out-of-scope Posted issue is not in scope of VS Code perf terminal-rendering
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 7, 2022

Needs xtermjs/xterm.js#4151 to land
@Tyriar Tyriar added debt Code quality issues perf terminal-rendering labels Oct 7, 2022
@Tyriar Tyriar added this to the October 2022 milestone Oct 7, 2022
@Tyriar Tyriar assigned Tyriar and meganrogge and unassigned meganrogge Oct 7, 2022
Tyriar added a commit that referenced this issue Oct 7, 2022
@Tyriar
Load terminal renderer addon before open is called
37a2386 
Fixes #162973
This was referenced Oct 7, 2022
Merged
Closed
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Oct 7, 2022
@Tyriar Tyriar reopened this Oct 7, 2022
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Oct 7, 2022
Tyriar added a commit that referenced this issue Oct 7, 2022
@Tyriar
Revert change to init renderer before open
0614215 
This was causing problems where webgl would not get activated

Reopened #162973
@Tyriar Tyriar mentioned this issue Oct 7, 2022
Merged
@meganrogge meganrogge modified the milestones: October 2022, Backlog Oct 10, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Dec 8, 2022

This caused a regression, the gain is minimal so just closing this out

@Tyriar Tyriar closed this as completed Dec 8, 2022
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues *out-of-scope Posted issue is not in scope of VS Code perf terminal-rendering
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Update xterm.js and avoid loading DOM renderer when not used microsoft/vscode
3 participants
@Tyriar @meganrogge @VSCodeTriageBot