Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt creating xterm.js renderer before open is called #162056

Closed
Tyriar opened this issue Sep 27, 2022 · 1 comment
Closed

Adopt creating xterm.js renderer before open is called #162056

Tyriar opened this issue Sep 27, 2022 · 1 comment
Assignees
@Tyriar
Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) perf

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2022

xterm.js will soon be able to avoid creating and immediately disposing the DOM renderer when we have the webgl renderer enabled:

xtermjs/xterm.js#4151
@Tyriar Tyriar added debt Code quality issues perf labels Sep 27, 2022
@Tyriar Tyriar added this to the October 2022 milestone Sep 27, 2022
@meganrogge meganrogge removed their assignment Oct 4, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Oct 7, 2022

/duplicate #162973

@Tyriar Tyriar closed this as completed Oct 7, 2022
@Tyriar Tyriar removed this from the October 2022 milestone Oct 7, 2022
@VSCodeTriageBot VSCodeTriageBot added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) perf
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tyriar @meganrogge @VSCodeTriageBot