Skip to content

Commit

Permalink
drop octicon usage in suggest
Browse files Browse the repository at this point in the history
  • Loading branch information
joaomoreno committed Aug 12, 2016
1 parent be4b971 commit 4dc127e
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/vs/editor/contrib/suggest/browser/back.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/vs/editor/contrib/suggest/browser/info.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions src/vs/editor/contrib/suggest/browser/suggest.css
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@
.monaco-editor .suggest-widget .monaco-list .monaco-list-row .docs > .docs-details {
font-size: 1.4em;
opacity: 0.6;
width: 14px;
height: 14px;
background-image: url('./info.svg');
background-size: 14px;
}

.monaco-editor .suggest-widget .details > .header > .go-back,
Expand Down Expand Up @@ -176,6 +180,10 @@
.monaco-editor .suggest-widget .details > .header > .go-back {
cursor: pointer;
opacity: 0.6;
width: 14px;
height: 14px;
background-image: url('./back.svg');
background-size: 14px;
}

.monaco-editor .suggest-widget .details > .header > .go-back:hover {
Expand Down
4 changes: 2 additions & 2 deletions src/vs/editor/contrib/suggest/browser/suggestWidget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class Renderer implements IRenderer<CompletionItem, ISuggestionTemplateData> {

const docs = append(text, $('.docs'));
data.documentation = append(docs, $('span.docs-text'));
data.documentationDetails = append(docs, $('span.docs-details.octicon.octicon-info'));
data.documentationDetails = append(docs, $('span.docs-details'));
data.documentationDetails.title = nls.localize('readMore', "Read More...{0}", this.triggerKeybindingLabel);

const configureFont = () => {
Expand Down Expand Up @@ -211,7 +211,7 @@ class SuggestionDetails {

const header = append(this.el, $('.header'));
this.title = append(header, $('span.title'));
this.back = append(header, $('span.go-back.octicon.octicon-mail-reply'));
this.back = append(header, $('span.go-back'));
this.back.title = nls.localize('goback', "Go back");
this.body = $('.body');

Expand Down

0 comments on commit 4dc127e

Please sign in to comment.