set expandGitHubIssueLinks
to inverse of noGitHubIssueLinking
#543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains handling
noGitHubIssueLinking
option and variableexpandGitHubIssueLinks
properly.According to
commandar
,noGitHubIssueLinking
can betrue
orundefined
, cannot befalse
because the option name doesn't start with--no-
.So
expandGitHubIssueLinks
is same.https://github.com/tj/commander.js#other-option-types-negatable-boolean-and-booleanvalue
On current implementation, the
expandGitHubIssueLinks
is alwaystrue
after this conditional operator ifexpandGitHubIssueLinks
cannot befalse
, as reported in #542vscode-vsce/src/package.ts
Lines 441 to 442 in f186af2