Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set expandGitHubIssueLinks to inverse of noGitHubIssueLinking #543

Closed
wants to merge 1 commit into from
Closed

set expandGitHubIssueLinks to inverse of noGitHubIssueLinking #543

wants to merge 1 commit into from

Conversation

horihiro
Copy link

@horihiro horihiro commented Mar 9, 2021

This PR contains handling noGitHubIssueLinking option and variable expandGitHubIssueLinks properly.

According to commandar, noGitHubIssueLinking can be true or undefined, cannot be false because the option name doesn't start with --no-.
So expandGitHubIssueLinks is same.
https://github.com/tj/commander.js#other-option-types-negatable-boolean-and-booleanvalue

On current implementation, the expandGitHubIssueLinks is always true after this conditional operator if expandGitHubIssueLinks cannot be false, as reported in #542

vscode-vsce/src/package.ts

Lines 441 to 442 in f186af2

this.expandGitHubIssueLinks =
typeof options.expandGitHubIssueLinks === 'boolean' ? options.expandGitHubIssueLinks : true;

@joaomoreno
Copy link
Member

A better fix is to just adopt the --no syntax: 83163ed

Thanks though!

@joaomoreno joaomoreno closed this Mar 12, 2021
@horihiro horihiro deleted the fix-option-noGitHubIssueLinking branch March 12, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants