Merge pull request #529 from microsoft/aeschli/productIconThemes

Support productIconThemes

src/package.ts

@@ -359,6 +359,7 @@ export class TagsProcessor extends BaseProcessor {
 
 		const colorThemes = doesContribute('themes') ? ['theme', 'color-theme'] : [];
 		const iconThemes = doesContribute('iconThemes') ? ['theme', 'icon-theme'] : [];
+		const productIconThemes = doesContribute('productIconThemes') ? ['theme', 'product-icon-theme'] : [];
 		const snippets = doesContribute('snippets') ? ['snippet'] : [];
 		const keybindings = doesContribute('keybindings') ? ['keybindings'] : [];
 		const debuggers = doesContribute('debuggers') ? ['debuggers'] : [];
@@ -394,6 +395,7 @@ export class TagsProcessor extends BaseProcessor {
 			...keywords,
 			...colorThemes,
 			...iconThemes,
+			...productIconThemes,
 			...snippets,
 			...keybindings,
 			...debuggers,

src/test/package.test.ts

@@ -916,6 +916,25 @@ describe('toVsixManifest', () => {
 			});
 	});
 
+	it('should automatically add product-icon-theme tag', () => {
+		const manifest = {
+			name: 'test',
+			publisher: 'mocha',
+			version: '0.0.1',
+			engines: Object.create(null),
+			contributes: {
+				productIconThemes: [{ id: 'fakeicons', label: 'fakeicons', path: 'fake.icons' }],
+			},
+		};
+
+		return _toVsixManifest(manifest, [])
+			.then(parseXmlManifest)
+			.then(result => {
+				const tags = result.PackageManifest.Metadata[0].Tags[0].split(',') as string[];
+				assert(tags.some(tag => tag === 'product-icon-theme'));
+			});
+	});
+
 	it('should automatically add language tag with activationEvent', () => {
 		const manifest = {
 			name: 'test',