Don't use npx for webpack build and update npm version

[IanMatthewHuff]

For #7197

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
• Title summarizes what is changing
• Has a news entry file (remember to thank yourself!)
• Appropriate comments and documentation strings in the code
• Has sufficient logging.
• Has telemetry for enhancements.
• Unit tests & system/integration tests are added/updated
• Test plan is updated as appropriate
• package-lock.json has been regenerated by running npm install (if dependencies have changed)
• The wiki is updated with any design decisions/details.

[DonJayamanne]

Will check, didn't know we could use npm run webpack
Hmmm

[IanMatthewHuff]

Context:
npx broke on windows with the -n parameter that we use at version 6.11.
npm/npx#5
As far as I can see npx doesn't seem to be getting much update attention, so I looked if I could move away from it.
npm/npx#30

The main missing thing from npm run was setting the memory limit up so I used the cross-env method from here:
npm/npm#12238

[IanMatthewHuff]

Will check, didn't know we could use npm run webpack
Hmmm

Worked for my local vscode build, npm run commands, and npm run package on windows and my mac. Something is up on the build machine though. I'll check that out.

[codecov-io]

Codecov Report

Merging #9387 into master will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9387      +/-   ##
==========================================
+ Coverage   60.73%   60.97%   +0.24%     
==========================================
  Files         550      529      -21     
  Lines       28748    28552     -196     
  Branches     4348     4333      -15     
==========================================
- Hits        17459    17409      -50     
+ Misses      10338    10192     -146     
  Partials      951      951

Impacted Files	Coverage Δ
src/client/testing/serviceRegistry.ts	49.09% <0%> (-47.28%)	⬇️
src/client/testing/codeLenses/main.ts	40% <0%> (-30%)	⬇️
src/client/datascience/jupyter/jupyterUtils.ts	61.11% <0%> (-27.78%)	⬇️
src/client/formatters/serviceRegistry.ts	75% <0%> (-25%)	⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts	50% <0%> (-25%)	⬇️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts	60% <0%> (-20%)	⬇️
...cience/jupyter/jupyterDebuggerNotInstalledError.ts	50% <0%> (-16.67%)	⬇️
src/client/common/utils/icons.ts	83.33% <0%> (-16.67%)	⬇️
src/client/api.ts	78.57% <0%> (-14.29%)	⬇️
src/client/datascience/cellFactory.ts	59.52% <0%> (-11.91%)	⬇️
... and 32 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8d808...c1ffd0a. Read the comment docs.

[IanMatthewHuff]

Sorry still a draft at this point. Forgot to mark as such.

[IanMatthewHuff]

istanbuljs/nyc#1205

[IanMatthewHuff]

NYC just flopped over with the newer NPM on windows. Was thankfully just fixed in a recent update to nyc 15.

[IanMatthewHuff]

Currently running nightly against this PR as well.

[rchiodo]

cross [](start = 35, length = 5)

Is this a replacement for npx?

[IanMatthewHuff]

@rchiodo No, basically just calling webpack and having webpack as a script entry replaces NPX. But cross-env is needed because of that -n parameter that we used with npx. That parameter gets passed as a node option to npm run. So to get around not having that cross-env is just a cross platform way to set an environment variable. That env-var then picks up the old space size setting when running webpack.

[rchiodo]

[kimadeline]

🚢