New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locator for pixi environments #22968
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree company="Prefix.dev GmbH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, please create an issue corresponding to the same, we hope to get to this shortly.
Ofc, see #22978 |
I took the time to also add tests. These are based on the ones from hatch and poetry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, I'm happy with it overall. If you could also work on the test plan item to verify it, that would be great. for eg. #21298, #21102.
See #22779 (comment) for similar ask from another tool, feel free to let me know if there's any questions,
Looking at #22779 (comment) this PR currently only adds discovery, (I would like to work on the rest after this). Would a test-plan like this suffice? Requirements:
Verification:
|
@baszalmstra maybe also add multi envs to the test plan? |
@pavelzw That sounds fine for discovery, I think this PR might also cover additional scenarios, as pixi environments are essential conda under the hood: Activation and Execution:Installation:
If this doesn't work, we might need to add a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflicts ⚔️ Here's an example test plan item for the Discovery & Activation part: #23088. Please @ me once this is done, unsubscribing for now.
Will this also work for R? |
I have added implementations of activation, a module installer, and execution. Will add a test plan one of these days! |
@karrtikr @karthiknadig whats the current state of this PR? I would love to get this available in vscode 😍 |
@baszalmstra Is this ready for review? |
Sorry for leaving this for so long. I am on a holiday but will be back next week. Im quite happy with the functionality provided by this PR. I think the biggest thing missing is the test plan. Also some unit tests might still be required, I could definitely use some help with those. |
Closes #22978
This adds a locator implementation that properly detects Pixi environments. Pixi environments are essentially conda environments but placed in a specific directory inside the project/workspace. This PR properly detects these and does not do much else. This would unblock a lot of pixi users.
I would prefer to use a custom pixi plugin but since the contribution endpoints are not available yet I think this is the next best thing.
Before I put more effort into tests I just want to verify that this approach is valid. Let me know what you think! :)