Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support yaml tests #22683

Closed
wants to merge 7 commits into from
Closed

Conversation

eleanorjboyd
Copy link
Member

fixes #22668

skip_test selected since tests are in Python and only change to a .ts file is error handling.

@eleanorjboyd eleanorjboyd added bug Issue identified by VS Code Team member as probable bug area-testing skip tests Updates to tests unnecessary labels Dec 19, 2023
@eleanorjboyd eleanorjboyd added this to the December / January 2024 milestone Dec 19, 2023
@eleanorjboyd eleanorjboyd self-assigned this Dec 19, 2023
@eleanorjboyd eleanorjboyd marked this pull request as draft December 19, 2023 19:46
@eleanorjboyd
Copy link
Member Author

The test for this change requires this plugin, https://pypi.org/project/pytest-mypy-plugins/, how do I support that? @karthiknadig

@aiday-mar aiday-mar modified the milestones: December / January 2024, February 2024 Jan 24, 2024
@eleanorjboyd eleanorjboyd marked this pull request as ready for review January 31, 2024 19:18
@eleanorjboyd
Copy link
Member Author

eleanorjboyd commented Feb 21, 2024

closing this pull request as yaml tests are not supported as a type in the basic pytest library and therefore I am unsure if we want to incorporate the yaml library into our testing infrastructure at this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yml test file breaks pytest test discovery
2 participants