Upgrade isort to 5.3.2

[karrtikr]

For #12949 #12932

Description of changes made: #12932 (comment)

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
• Title summarizes what is changing.
• Has a news entry file (remember to thank yourself!).
• Appropriate comments and documentation strings in the code.
• Has sufficient logging.
• Has telemetry for enhancements.
• Unit tests & system/integration tests are added/updated.
• Test plan is updated as appropriate.
• package-lock.json has been regenerated by running npm install (if dependencies have changed).
• The wiki is updated with any design decisions/details.

[codecov-commenter]

Codecov Report

Merging #13340 into master will decrease coverage by 0.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13340      +/-   ##
==========================================
- Coverage   59.64%   58.99%   -0.66%     
==========================================
  Files         670      671       +1     
  Lines       36830    39573    +2743     
  Branches     5188     5965     +777     
==========================================
+ Hits        21968    23345    +1377     
- Misses      13770    15019    +1249     
- Partials     1092     1209     +117     

Impacted Files	Coverage Δ
src/client/datascience/notebook/contentProvider.ts	44.44% <0.00%> (-5.56%)	⬇️
src/client/datascience/commands/commandRegistry.ts	28.35% <0.00%> (-5.44%)	⬇️
src/client/datascience/jupyter/jupyterExporter.ts	11.18% <0.00%> (-4.14%)	⬇️
src/client/datascience/jupyter/jupyterRequest.ts	12.50% <0.00%> (-2.89%)	⬇️
...client/datascience/raw-kernel/rawJupyterSession.ts	13.38% <0.00%> (-2.79%)	⬇️
...ascience/jupyter/liveshare/guestJupyterNotebook.ts	6.84% <0.00%> (-2.72%)	⬇️
src/datascience-ui/interactive-common/mainState.ts	54.76% <0.00%> (-2.39%)	⬇️
...lient/datascience/jupyter/jupyterSessionManager.ts	6.75% <0.00%> (-2.28%)	⬇️
src/client/datascience/jupyter/jupyterServer.ts	7.23% <0.00%> (-2.03%)	⬇️
...client/datascience/kernel-launcher/kernelDaemon.ts	8.69% <0.00%> (-1.84%)	⬇️
... and 33 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cf27d...08fda48. Read the comment docs.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
2 Code Smells

No Coverage information
1.1% Duplication

[janosh]

Is this ready to merge?

[karrtikr]

Hey @int19h Maybe the notification got skipped, but this PR has been blocked on your review since a week. Can you please review?

[janosh]

@karrtikr @int19h Thanks a lot!

Is there a way to verify which version of isort is being used for sorting imports on save? I looked in the Python extension's output panel but only found ~/.vscode/extensions/ms-python.python-2020.9.102493-dev/pythonFiles/sortImports.py - --diff.

[karrtikr]

You can edit the sortImports.py file to print the isort version and then run the file directly yourself.