Attempt workaround for microsoft/vscode#60187

microsoft · Nov 13, 2018 · c9feb12 · c9feb12
1 parent 19cb40c
commit c9feb12
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -366,6 +366,11 @@
                 "type": "boolean",
                 "description": "%node.enableSourceMapCaching.description%",
                 "default": true
+              },
+              "_disableOptimisticBPs": {
+                "type": "boolean",
+                "description": "Don't set breakpoints in any file until a sourcemap has been loaded for that file.",
+                "default": true
               }
             }
           },
@@ -481,6 +486,11 @@
                 "type": "boolean",
                 "description": "%node.enableSourceMapCaching.description%",
                 "default": true
+              },
+              "_disableOptimisticBPs": {
+              	"type": "boolean",
+              	"description": "Don't set breakpoints in any file until a sourcemap has been loaded for that file.",
+              	"default": true
               }
             }
           }

diff --git a/src/nodeDebugAdapter.ts b/src/nodeDebugAdapter.ts
@@ -705,7 +705,7 @@ export class NodeDebugAdapter extends ChromeDebugAdapter {
 
     protected validateBreakpointsPath(args: ISetBreakpointsArgs): Promise<void> {
         return super.validateBreakpointsPath(args).catch(e => {
-            if (args.source.path && utils.isJavaScript(args.source.path)) {
+            if (!this._launchAttachArgs._disableOptimisticBPs && args.source.path && utils.isJavaScript(args.source.path)) {
                 return undefined;
             } else {
                 return Promise.reject(e);

diff --git a/src/nodeDebugInterfaces.d.ts b/src/nodeDebugInterfaces.d.ts
@@ -17,6 +17,9 @@ export interface ICommonRequestArgs extends Core.ICommonRequestArgs {
     cwd?: string;
     /** Request frontend to restart session on termination. */
     restart?: boolean;
+
+    /** Don't set breakpoints in JS files that don't have sourcemaps */
+    _disableOptimisticBPs?: boolean;
 }
 
 /**