Update to sqltoolsservice 5.0.0.4 and remove specific Linux distros #17890
Conversation
|
@microsoft-github-policy-service agree |
|
@kisantia @kburtram FYI - what would probably be even better is to remove the specific distros and instead move to the generic "Linux" target that Alan added support for in the downloader a while back. That will give us forward compatibility too. e.g. what we do in MSSQL extension : https://github.com/microsoft/azuredatastudio/blob/main/extensions/mssql/config.json |
|
@Charles-Gagnon I removed the specific distros and moved to the current release of sqltoolsservice. |
maxvolk
changed the title
| }, | ||
| "installDir": "../sqltoolsservice/{#version#}/{#platform#}", | ||
| "executableFiles": [ | ||
| "MicrosoftSqlToolsServiceLayer.exe", | ||
| "MicrosoftSqlToolsServiceLayer", | ||
| "MicrosoftSqlToolsServiceLayer.dll" | ||
| ] | ||
| }, | ||
| "v1Service": { |
There was a problem hiding this comment.
This is still used for downlevel Mac versions so we should keep it as-is for now
There was a problem hiding this comment.
What would be the rule or trade-off when one could remove such support for these old Mac OS versions? Or is in general the goal to offer maximum support to older versions?
There was a problem hiding this comment.
We've never really set a goal or deprecation timeline, but that's definitely something we should work on! For now though continuing to support all previous versions is something we strive to adhere to.
|
Thanks for going through and updating all this @maxvolk! To confirm - is this a blocking issue for you on Ubuntu 22 right now? |
This issue is not blocking me on Ubuntu right now, it stems more from curiosity. |
|
Gotcha, thanks! Since it's not blocking we might take a bit to get to this due to some other higher priority stuff, but this is definitely work we'll want to take so we'll get to it once we have some time! If this becomes a higher priority issue for any reason let us know and I can see what we can do. |
Currently, the most recent Ubuntu version is 16. This PR adds those LTS versions up to the most recently released one (22).