Enable multiple provders #17834
Open
Enable multiple provders #17834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.vscodeWrapper = vscodeWrapper; | ||
| this.logger = logger; | ||
|
|
||
| vscode.workspace.onDidChangeConfiguration((changeEvent) => { |
There was a problem hiding this comment.
I'm not sure why this class would be needed.. since we only have MSAL now, what is the purpose of moving code here?
There was a problem hiding this comment.
You mean azureAccountProvider? I created it to handle the mappings of different auth providers such as public cloud, china cloud, gov cloud
There was a problem hiding this comment.
Had a chat with Cheena offline, will be refactoring this to be inside msalAzureController
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
…t/vscode-mssql into chsuh/multipleProviders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the China Cloud & US Gov cloud as options for users to authenticate to.