-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix electron 22 crash: update zeromq. #12970
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this required, apart from the fact that its a little bit more recent that the previous.
Some information (probably an issue would be great)
This way when we go bakc and look at ths history we know why things were updated.
@DonJayamanne thanks for pointing that out. PR created in a hurry. I have updated the issue description to explain why this update is needed. |
@rebornix no worries, saw the messages, and realized what it was , |
371797b
to
a74b072
Compare
4eb1ff1
to
0b8a6eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please could you test this vsix on windows
I don’t think it will work, I haven’t tried it myself
Please have a look at my pr
You might also need to copy the nodegyp files
Else the vsix will not work on windows or apple intel now will it work on Linux
It will still fallback to Jupyter and Zamboanga will not load
Prepare for the upcoming 1.77 Insiders. 1.77 ships with Electron 22, which introduces v8 memory cage. Current zeromq will crash with Electron 22. The issue was already fixed in a newer version of zeromq zeromq/zeromq.js#514 .
More details about the v8 memory cage electron/electron#36624
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).