Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for eslint.codeActionsOnSave.rules mechanism #1364

Merged
merged 5 commits into from
Nov 18, 2021

Commits on Nov 10, 2021

  1. saveRuleConfigCache is indexed by file path not uri

    When adding new entries to saveRuleConfigCache those entries are indexed by file path (lines 589 and 592), but we are trying to delete them by URI. This is causing cache entries to become stale if the settings are changed.
    edupsousa committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    63e3556 View commit details
    Browse the repository at this point in the history
  2. getSaveRuleConfig returns undefined with eslint@8

    The function getSaveRuleConfig returns undefined on eslint@8 unless the setting eslint.useESLintClass == true, but there's no point on using this setting with eslint@8 as the CLIEngine is no longer available.
    
    To fix this I changed the condition to check if the ESLintClass.isCliEngine == true, this way we can keep the logic about the engine selection and capabilities only within the ESLintClass.newESLintClass function.
    edupsousa committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    492858e View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Configuration menu
    Copy the full SHA
    786bf9d View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Configuration menu
    Copy the full SHA
    0527347 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    00c1f75 View commit details
    Browse the repository at this point in the history