Remove dead, buggy code #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exists with an assert instead. SingleExecuteProtector can only ever be constructed with a non-null job (validates with Requires.NotNull) and the job is only set to null after TryExecute succeeds. Therefore the job will exist if TryExecute has an invokeDelegate (i.e. has not yet executed). Removed the #pragma that disabled the CS8602 warning.
AArnott
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the condition checking whether
this.jobexists with an assert (like is used elsewhere), and removed the #pragma that disabled the CS8602 warning.My reasoning is that
SingleExecuteProtectorcan only ever be constructed with a non-null job (validates withRequires.NotNull) and the job is only set to null whenTryExecutesucceeds. Therefore if TryExecute reaches line 1230 then the job will exist.Closes #544