Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSTHRD010 now recognizes when struct members require the main thread #869

Merged
merged 2 commits into from Jul 9, 2021
Merged

VSTHRD010 now recognizes when struct members require the main thread #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3db4ce
Fixes #456. VSTHRD010 now recognizes when struct members require the …
bluetarpmedia Jun 28, 2021
74996f4
Corrected some Cast test cases where the interface type was actually …
bluetarpmedia Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.VisualStudio.Threading.Analyzers.CSharp/VSTHRD010MainThreadUsageAnalyzer.cs
View file
Open in desktop
Expand Up @@ -443,7 +443,7 @@ private bool AnalyzeMemberWithinContext(ITypeSymbol type, ISymbol? symbol, Synta
throw new ArgumentNullException(nameof(type));
}

bool requiresUIThread = (type.TypeKind == TypeKind.Interface || type.TypeKind == TypeKind.Class)
bool requiresUIThread = (type.TypeKind == TypeKind.Interface || type.TypeKind == TypeKind.Class || type.TypeKind == TypeKind.Struct)
&& this.MembersRequiringMainThread.Contains(type, symbol);

if (requiresUIThread)
Expand Down
1 change: 1 addition & 0 deletions ...reading.Analyzers.Tests/AdditionalFiles/vs-threading.MembersRequiringMainThread.mocks.txt
View file
Open in desktop
@@ -1,4 +1,5 @@
[TestNS.*]
[TestNS.SomeStruct]
![TestNS.FreeThreadedType]
![TestNS2.FreeThreadedType]
[TestNS2.*]
Expand Down
46 changes: 43 additions & 3 deletions ...Microsoft.VisualStudio.Threading.Analyzers.Tests/VSTHRD010MainThreadUsageAnalyzerTests.cs
View file
Open in desktop
Expand Up @@ -970,7 +970,7 @@ public async Task CastToManagedType_ProducesNoDiagnostic()

namespace TestNS {
class SomeClass { }
class SomeInterface { }
interface SomeInterface { }
}

class Test {
Expand Down Expand Up @@ -1053,7 +1053,7 @@ public async Task CastToManagedTypeViaAs_ProducesNoDiagnostic()

namespace TestNS {
class SomeClass { }
class SomeInterface { }
interface SomeInterface { }
}

class Test {
Expand Down Expand Up @@ -1096,7 +1096,7 @@ public async Task CastToManagedTypeViaIs_ProducesNoDiagnostic()

namespace TestNS {
class SomeClass { }
class SomeInterface { }
interface SomeInterface { }
}

class Test {
Expand Down Expand Up @@ -1864,6 +1864,46 @@ async void SecondAsync()
await Verify.VerifyAnalyzerAsync(test, expect);
}

[Fact]
public async Task StructMembers()
{
var test = @"
namespace TestNS
{
struct SomeStruct
{
public static void DoSomething()
{
}

public string Name { get; set; }
}
}

namespace Foo
{
class MyProgram
{
static void Main()
{
TestNS.SomeStruct.DoSomething();

var st = new TestNS.SomeStruct();
st.Name = ""TheValue"";
string val = st.Name;
}
}
}
";
var expect = new DiagnosticResult[]
{
Verify.Diagnostic(DescriptorSync).WithSpan(20, 31, 20, 42).WithArguments("SomeStruct", "Test.VerifyOnUIThread"),
Verify.Diagnostic(DescriptorSync).WithSpan(23, 16, 23, 20).WithArguments("SomeStruct", "Test.VerifyOnUIThread"),
Verify.Diagnostic(DescriptorSync).WithSpan(24, 29, 24, 33).WithArguments("SomeStruct", "Test.VerifyOnUIThread"),
};
await Verify.VerifyAnalyzerAsync(test, expect);
}

private static class CodeFixIndex
{
public const int SwitchToMainThreadAsync = 0;
Expand Down