Update VSTHRD110 to handle conditional access expressions #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionSyntax parent of the invocation.
|
Linux job had these errors; problem with the agent? |
AArnott
changed the title
AArnott
approved these changes
Jun 22, 2021
| @@ -46,7 +46,7 @@ internal void AnalyzeInvocation(SyntaxNodeAnalysisContext context) | |||
|
|
|||
| // Only consider invocations that are direct statements. Otherwise, we assume their | |||
| // result is awaited, assigned, or otherwise consumed. | |||
| if (invocation.Parent?.GetType().Equals(typeof(ExpressionStatementSyntax)) ?? false) | |||
| if (invocation.Parent is ExpressionStatementSyntax || invocation.Parent is ConditionalAccessExpressionSyntax) | |||
There was a problem hiding this comment.
tip: this can be written even more succinctly as:
if (invocation.Parent is ExpressionStatementSyntax or ConditionalAccessExpressionSyntax)There was a problem hiding this comment.
Thanks! Good to know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSTHRD110 now detects a ConditionalAccessExpressionSyntax parent of the invocation.
Closes #772