Suppress reporting VSTHRD114 diagnostic on Task?
returning methods
#866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSTHRD114 now ignores C# methods returning
Task?
Converted VSTHRD114 to an abstract base class in order to use LanguageUtils.
This implementation uses syntax nodes to detect the nullable return type, which means the Roslyn CodeAnalysis does not need to be upgraded.
It prevents VSTHRD114 warnings on cases like these:
But it doesn't prevent warnings for anonymous functions or lambdas, like:
If and when the Roslyn upgrade happens the implementation can be simplified to use IMethodSymbol.ReturnNullableAnnotation and that will solve the anon/lambda cases too.
Closes #637