Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover ReentrantSemaphore after JTF throws an exception #844

Merged
merged 3 commits into from May 5, 2021
Merged

Recover ReentrantSemaphore after JTF throws an exception #844

merged 3 commits into from May 5, 2021

Commits on May 4, 2021

  1. Recover ReentrantSemaphore after JTF throws an exception 

    We already had a try/finally block, but it assumed JTF.RunAsync itself wouldn't throw an exception. In some cases it *does* throw an exception (`OutOfMemoryException` for example) and it's critical to avoiding deadlocks later on that we exit the semaphore we entered in this case so we do not deadlock later.

Fixes microsoft#843
    @AArnott
    AArnott committed May 4, 2021
    Copy the full SHA
    9a5e278 View commit details
    Browse the repository at this point in the history

  2. Expand try blocks in ReentrantSemaphore even further

    @AArnott
    AArnott committed May 4, 2021
    Copy the full SHA
    a7b2a04 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/v16.10' into improveSemaphoreR… 

    …eliability
    @AArnott
    AArnott committed May 4, 2021
    Copy the full SHA
    9f2c0e3 View commit details
    Browse the repository at this point in the history