Dev/trevors/mbpresteps broken template/testnewmbpresteps #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finishes what bb38a72 started
These need to be set before we have a chance to run our variable ps1 scripts.
It's disabled by default, but is easy to turn on.
By requiring opt-in to sign on mac/linux, we remove the need for signing re-approval on pipelines that are already signing. It also avoids signing binaries that typically will not ship anyway.
These are redundant with those injected by 1ES PT.
CodeQL is injected by default by the 1ES PT templates now, so we don't need this variable.
1ES PT includes it already.
This should reduce merge conflicts going forward since the job's content doesn't entirely change just to enable it.
It publishes to a web site that no longer operates.
Setting it to `$(Pipeline.Workspace)` was problematic because it included other files dropped by 1ES PT that credscan then failed on (go figure). And anyway, these jobs have only one output so there's no reason to specify `outputParentDirectory` as no optimization is applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See if it will launch a build or not...