Merge pull request #889 from davkean/AvoidReadingResourcesHoldingSema…

…phore Avoid reading resource unless needed
microsoft · Aug 17, 2021 · ed8ffea · ed8ffea
2 parents af5364d + 8eaab9d
commit ed8ffea
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/Microsoft.VisualStudio.Threading/ReentrantSemaphore.cs b/src/Microsoft.VisualStudio.Threading/ReentrantSemaphore.cs
@@ -899,7 +899,10 @@ public override RevertRelevance SuppressRelevance()
             /// </summary>
             protected override void ThrowIfFaulted()
             {
-                Verify.Operation(!this.faulted, Strings.SemaphoreMisused);
+                if (this.faulted)
+                {
+                    throw Verify.FailOperation(Strings.SemaphoreMisused);
+                }
             }
         }