Merge pull request #987 from n9/feature/GetQueueElements

AsyncQueue<T>.ToArray() made public (#986)
microsoft · Feb 11, 2022 · 7e66041 · 7e66041
2 parents 26b09cb + 17cfe3a
commit 7e66041
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 1 deletion.
diff --git a/src/Microsoft.VisualStudio.Threading/AsyncQueue`1.cs b/src/Microsoft.VisualStudio.Threading/AsyncQueue`1.cs
@@ -324,7 +324,7 @@ public bool TryDequeue([MaybeNullWhen(false)] out T value)
         /// <summary>
         /// Returns a copy of this queue as an array.
         /// </summary>
-        internal T[] ToArray()
+        public T[] ToArray()
         {
             lock (this.SyncRoot)
             {

diff --git a/src/Microsoft.VisualStudio.Threading/net472/PublicAPI.Unshipped.txt b/src/Microsoft.VisualStudio.Threading/net472/PublicAPI.Unshipped.txt
@@ -1,3 +1,4 @@
+Microsoft.VisualStudio.Threading.AsyncQueue<T>.ToArray() -> T[]!
 Microsoft.VisualStudio.Threading.AsyncReaderWriterLock.AsyncReaderWriterLock(Microsoft.VisualStudio.Threading.JoinableTaskContext? joinableTaskContext, bool captureDiagnostics = false) -> void
 Microsoft.VisualStudio.Threading.AsyncReaderWriterResourceLock<TMoniker, TResource>.AsyncReaderWriterResourceLock(Microsoft.VisualStudio.Threading.JoinableTaskContext? joinableTaskContext, bool captureDiagnostics) -> void
 Microsoft.VisualStudio.Threading.JoinableTaskContext.IsMainThreadMaybeBlocked() -> bool

diff --git a/src/Microsoft.VisualStudio.Threading/netcoreapp3.1/PublicAPI.Unshipped.txt b/src/Microsoft.VisualStudio.Threading/netcoreapp3.1/PublicAPI.Unshipped.txt
@@ -1,3 +1,4 @@
+Microsoft.VisualStudio.Threading.AsyncQueue<T>.ToArray() -> T[]!
 Microsoft.VisualStudio.Threading.AsyncReaderWriterLock.AsyncReaderWriterLock(Microsoft.VisualStudio.Threading.JoinableTaskContext? joinableTaskContext, bool captureDiagnostics = false) -> void
 Microsoft.VisualStudio.Threading.AsyncReaderWriterResourceLock<TMoniker, TResource>.AsyncReaderWriterResourceLock(Microsoft.VisualStudio.Threading.JoinableTaskContext? joinableTaskContext, bool captureDiagnostics) -> void
 Microsoft.VisualStudio.Threading.JoinableTaskContext.IsMainThreadMaybeBlocked() -> bool

diff --git a/src/Microsoft.VisualStudio.Threading/netstandard2.0/PublicAPI.Unshipped.txt b/src/Microsoft.VisualStudio.Threading/netstandard2.0/PublicAPI.Unshipped.txt
@@ -1,3 +1,4 @@
+Microsoft.VisualStudio.Threading.AsyncQueue<T>.ToArray() -> T[]!
 Microsoft.VisualStudio.Threading.AsyncReaderWriterLock.AsyncReaderWriterLock(Microsoft.VisualStudio.Threading.JoinableTaskContext? joinableTaskContext, bool captureDiagnostics = false) -> void
 Microsoft.VisualStudio.Threading.AsyncReaderWriterResourceLock<TMoniker, TResource>.AsyncReaderWriterResourceLock(Microsoft.VisualStudio.Threading.JoinableTaskContext? joinableTaskContext, bool captureDiagnostics) -> void
 Microsoft.VisualStudio.Threading.JoinableTaskContext.IsMainThreadMaybeBlocked() -> bool

diff --git a/test/Microsoft.VisualStudio.Threading.Tests/AsyncQueueTests.cs b/test/Microsoft.VisualStudio.Threading.Tests/AsyncQueueTests.cs
@@ -25,6 +25,7 @@ public void JustInitialized()
         Assert.Equal(0, this.queue.Count);
         Assert.True(this.queue.IsEmpty);
         Assert.False(this.queue.Completion.IsCompleted);
+        Assert.Empty(this.queue.ToArray());
     }
 
     [Fact]
@@ -34,6 +35,7 @@ public void Enqueue()
         this.queue.Enqueue(value);
         Assert.Equal(1, this.queue.Count);
         Assert.False(this.queue.IsEmpty);
+        Assert.Single(this.queue.ToArray());
     }
 
     [Fact]
@@ -43,6 +45,7 @@ public void TryEnqueue()
         Assert.True(this.queue.TryEnqueue(value));
         Assert.Equal(1, this.queue.Count);
         Assert.False(this.queue.IsEmpty);
+        Assert.Single(this.queue.ToArray());
     }
 
     [Fact]