Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flatbuffers] Fix config filename when crosscompiling #29953

Merged
merged 1 commit into from Mar 2, 2023

Conversation

Eisenheim9
Copy link
Contributor

The CMake config file has been renamed from Flatbuffers-config.cmake to flatbuffers-config.cmake since google/flatbuffers#7502. When cross-compiling the flatc target include is appended to the old file, which leads to errors when CMake is trying to find the flatbuffers::flatc target. This PR fixes the config filename.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Eisenheim9
Copy link
Contributor Author

@microsoft-github-policy-service agree

@MonicaLiu0311 MonicaLiu0311 added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Mar 2, 2023
@dan-shaw dan-shaw merged commit 7074f8d into microsoft:master Mar 2, 2023
@Eisenheim9 Eisenheim9 deleted the fix-flatc-target branch March 2, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants