[flatbuffers] Update to 2.0.8 #26891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaLiu0311
added
the
category:port-update
MonicaLiu0311
previously approved these changes
Sep 21, 2022
MonicaLiu0311
added
the
info:reviewed
JonLiu1993
removed
the
info:reviewed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@JulZimmermann , Thanks for your pr, please get failure logs here. Please ping me if you need any help. |
JulZimmermann
dismissed stale reviews from github-actions and MonicaLiu0311
via
f8ae3b0
|
Looks like this is caused by google/flatbuffers#7499 and fixed with google/flatbuffers#7502. The fix isn't included in the 2.0.8 release. I created a patch with the changes from google/flatbuffers#7502. |
|
@JulZimmermann |
|
@JulZimmermann , ping for response. |
|
@JulZimmermann |
|
Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
updates version to 2.0.8.
removes patch
no-werror: -Werror isn't set by default anymoreremoves patch
ignore_use_of_cmake_toolchain_file: Seems not needed anymoreDoes your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes