Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix minimum test build failure #1272

Merged
merged 12 commits into from
Apr 21, 2023
Merged

CI: fix minimum test build failure #1272

merged 12 commits into from
Apr 21, 2023

Conversation

adamjstewart
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the testing Continuous integration testing label Apr 21, 2023
@github-actions github-actions bot added the dependencies Packaging and dependencies label Apr 21, 2023
@calebrob6
Copy link
Member

did ubuntu-latest change?

@github-actions github-actions bot removed the dependencies Packaging and dependencies label Apr 21, 2023
@github-actions github-actions bot added the dependencies Packaging and dependencies label Apr 21, 2023
@github-actions github-actions bot removed the testing Continuous integration testing label Apr 21, 2023
@adamjstewart
Copy link
Collaborator Author

I think this is working now. My best guess as to what broke is the latest setuptools release (v67.7.1) which came out last night. This specifically contains pypa/setuptools#3900, which "fixes" pypa/setuptools#3898, which looks suspiciously similar to our issue.

Our minimum tests should pin us to an older version of setuptools, but pip is allowed to install a newer version of setuptools in the background that is used only at build time. I tried constraining us to an older setuptools but that didn't help, so maybe constraints files only affect the final version that gets installed. Anyway, using a newer version of pycocotools avoids the use of deprecated features, so I think it's worth upgrading anyway. Hopefully someday they'll ship wheels.

@adamjstewart adamjstewart added this to the 0.4.2 milestone Apr 21, 2023
@adamjstewart adamjstewart marked this pull request as ready for review April 21, 2023 19:54
@calebrob6 calebrob6 enabled auto-merge (squash) April 21, 2023 20:03
@calebrob6 calebrob6 merged commit cc527f1 into main Apr 21, 2023
18 checks passed
@calebrob6 calebrob6 deleted the ci/fix-minimum branch April 21, 2023 20:04
@adamjstewart adamjstewart modified the milestones: 0.4.2, 0.5.0 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebrob6 calebrob6 calebrob6 approved these changes

Assignees
No one assigned
Labels
dependencies Packaging and dependencies
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamjstewart @calebrob6