Avoid conditionals inside assertions analyzer #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
May 14, 2024
...itTests/MSTest.Analyzers.UnitTests/AssertionArgsShouldAvoidConditionalAccessAnalyzerTests.cs
Show resolved
Hide resolved
...itTests/MSTest.Analyzers.UnitTests/AssertionArgsShouldAvoidConditionalAccessAnalyzerTests.cs
Show resolved
Hide resolved
src/Analyzers/MSTest.Analyzers/AssertionArgsShouldAvoidConditionalAccessAnalyzer.cs
Outdated
Show resolved
Hide resolved
...itTests/MSTest.Analyzers.UnitTests/AssertionArgsShouldAvoidConditionalAccessAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
May 14, 2024
...itTests/MSTest.Analyzers.UnitTests/AssertionArgsShouldAvoidConditionalAccessAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
May 14, 2024
src/Analyzers/MSTest.Analyzers/AssertionArgsShouldAvoidConditionalAccessAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/MSTest.Analyzers/AssertionArgsShouldAvoidConditionalAccessAnalyzer.cs
Outdated
Show resolved
Hide resolved
...itTests/MSTest.Analyzers.UnitTests/AssertionArgsShouldAvoidConditionalAccessAnalyzerTests.cs
Show resolved
Hide resolved
...itTests/MSTest.Analyzers.UnitTests/AssertionArgsShouldAvoidConditionalAccessAnalyzerTests.cs
Show resolved
Hide resolved
Evangelink
previously approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM thank you for the nice implementation and the fast updates @fhnaseer 
Could you please do a follow-up PR to dotnet/docs for this rule? Here is an example PR: dotnet/docs#40785
nohwnd
reviewed
May 15, 2024
Evangelink
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2751
Example:
// Warning
Assert.AreEqual(a?.b, "something");
// Fix
Assert.IsNotNull(a);
Assert.AreEqual(a.b, "something");