Fix parameters/arguments check for data driven tests #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
previously approved these changes
May 7, 2024
src/Adapter/MSTest.TestAdapter/Extensions/MethodInfoExtensions.cs
Outdated
Show resolved
Hide resolved
Evangelink
changed the title
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Evangelink
previously approved these changes
May 7, 2024
…ft/testfx into fix-parameter-validation
Evangelink
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes regression, where we validate types of provided data (e.g. in
[DataRow]) to the expected parameters of the test method exactly by their types. This is too strict and will fail for any types that can implicitly convert.This PR simply invokes the method, and relies on runtime to do the right checks, and we just handle and improve the exceptions that it throws. We only handle the two that are documented here: https://learn.microsoft.com/en-us/dotnet/api/system.reflection.methodbase.invoke?view=net-8.0 as happening when parameters don't match the target method.
As a result, user can provide int32 number to int64 parameter and it will work. As mentioned in the linked issue.
Fix #2828